Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22462#discussion_r219016643
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/sources/StreamingDataSourceV2Suite.scala
---
@@ -204,6 +249,37 @@ class StreamingDataSourceV2Suite extends StreamTest {
}
}
+ Seq(
+ Tuple2(classOf[FakeReadMicroBatchOnly], Trigger.Once()),
+ Tuple2(classOf[FakeReadContinuousOnly], Trigger.Continuous(1000))
+ ).foreach { case (source, trigger) =>
+ test(s"SPARK-25460: session options are respected in structured
streaming sources - $source") {
+ // `keyPrefix` and `shortName` are the same in this test case
+ val readSource = source.newInstance().shortName()
+ val writeSource = "fake-write-microbatch-continuous"
+
+ val readOptionName = "optionA"
+ withSQLConf(s"spark.datasource.$readSource.$readOptionName" ->
"true") {
+ testPositiveCase(readSource, writeSource, trigger, shouldStop =
false)
--- End diff --
why not stop the query?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
