Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22448#discussion_r219019347
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
 ---
    @@ -366,7 +366,29 @@ class TypeCoercionSuite extends AnalysisTest {
         // No up-casting for fixed-precision decimal (this is handled by 
arithmetic rules)
         widenTest(DecimalType(2, 1), DecimalType(3, 2), None)
         widenTest(DecimalType(2, 1), DoubleType, None)
    -    widenTest(DecimalType(2, 1), IntegerType, None)
    +    widenTest(DecimalType(2, 1), IntegerType, Some(DecimalType(11, 1)))
    --- End diff --
    
    @cloud-fan OK.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to