Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/22482
The patch is a bit huge, so I'm not sure we would be better to squash
commits into one before reviewing.
Two TODOs are left hence marking the patch as WIP, but closer to be a
complete patch:
1. Optimal implementation of state for session window.
It borrowed the state implementation from streaming join since it fits the
necessary concept of state for session window, but it may not be optimal one so
I'm going to see we can have better implementation.
2. Javadoc (Maybe structured streaming guide doc too?)
I didn't add javadoc yet to speed up POC and actual development, but to
complete the patch I guess I need to write javadoc for new classes as well as
methods (maybe).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
