GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22494
[SPARK-22036][SQL][followup] DECIMAL_OPERATIONS_ALLOW_PREC_LOSS should
cover all the behavior changes
## What changes were proposed in this pull request?
https://github.com/apache/spark/pull/20023 proposed to allow precision lose
during decimal operations, to reduce the possibilities of overflow. This is a
behavior change and is protected by the DECIMAL_OPERATIONS_ALLOW_PREC_LOSS
config. However, this config doesn't cover all the code paths. This PR fixes it.
More context:
The behavior change of #20023 exposed a long-standing bug about negative
scale, which is hard to fix. For details see
https://issues.apache.org/jira/browse/SPARK-25454 .
## How was this patch tested?
a new test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark decimal
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22494.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22494
----
commit 0f6ec74dbac4b1093e3b0fdef86a43aa7237ad05
Author: Wenchen Fan <wenchen@...>
Date: 2018-09-20T12:15:41Z
DECIMAL_OPERATIONS_ALLOW_PREC_LOSS should cover all the behavior changes
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
