Github user gengliangwang commented on the issue:

    https://github.com/apache/spark/pull/22513
  
    > KryoBenchmark is in core, and UnsafeProjectionBenchmark, 
HashByteArrayBenchmark and HashBenchmark are in catalyst. If we move the 
benchmark base class to sql, benchmarks mentioned above would not be able to 
inherit from the benchmark base class. What do you think?
    
    @wangyum The cases you mentioned are currently using the 
`org.apache.spark.sql.execution.benchmark.BenchmarkBase` (the old one), so it 
seems fine.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to