Github user wangyum commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22501#discussion_r219725654
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/WideSchemaBenchmark.scala
 ---
    @@ -17,22 +17,19 @@
     
     package org.apache.spark.sql
     
    -import java.io.{File, FileOutputStream, OutputStream}
    +import java.io.File
     
    -import org.scalatest.BeforeAndAfterEach
    -
    -import org.apache.spark.SparkFunSuite
    -import org.apache.spark.sql.functions._
    -import org.apache.spark.util.{Benchmark, Utils}
    +import org.apache.spark.util.{Benchmark, BenchmarkBase => 
FileBenchmarkBase, Utils}
     
     /**
      * Benchmark for performance with very wide and nested DataFrames.
    - * To run this:
    - *  build/sbt "sql/test-only *WideSchemaBenchmark"
    - *
    - * Results will be written to 
"sql/core/benchmarks/WideSchemaBenchmark-results.txt".
    + * To run this benchmark:
    + * 1. without sbt: bin/spark-submit --class <this class> <spark sql test 
jar>
    + * 2. build/sbt "sql/test:runMain <this class>"
    + * 3. generate result: SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt 
"sql/test:runMain <this class>"
    + *    Results will be written to 
"benchmarks/WideSchemaBenchmark-results.txt".
    --- End diff --
    
    Thanks @dongjoon-hyun. Actually I'm waiting for 
https://github.com/apache/spark/pull/22484. I want to move  `withTempDir()` to  
`RunBenchmarkWithCodegen.scala`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to