Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/22485#discussion_r219859567
--- Diff:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java
---
@@ -56,7 +56,7 @@ public void getMetrics(MetricsCollector collector,
boolean all) {
/**
* The metric types used in {@link
ExternalShuffleBlockHandler.ShuffleMetrics}
*/
- private static void collectMetric(MetricsRecordBuilder
metricsRecordBuilder, String name, Metric metric) {
--- End diff --
we should add a comment to the java "Exposed for testing."
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
