Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/22540#discussion_r220272980
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowUtils.scala
---
@@ -131,11 +131,8 @@ object ArrowUtils {
} else {
Nil
}
- val pandasColsByPosition = if
(conf.pandasGroupedMapAssignColumnssByPosition) {
--- End diff --
It's not a big deal performance wise, but does add something. I don't think
this is really necessary because the worker has to specify a default value that
matches the SQLConf anyway, so I would leave as is but it's fine if you prefer
to change it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
