Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22549#discussion_r220383364
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -388,10 +388,11 @@ private[spark] class AppStatusListener(
job.completionTime = if (event.time > 0) Some(new Date(event.time))
else None
update(job, now, last = true)
+ if(job.status.equals(JobExecutionStatus.SUCCEEDED)) {
--- End diff --
Nits: space after `if`. Can we write `job.stats ==
JobExecutionStatus.SUCCEEDED`? might be more idiomatic.
Certainly the result of the change looks reasonable, but I don't know this
code enough to be sure it's the right change. It seems reasonable.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
