Github user holdenk commented on the issue:

    https://github.com/apache/spark/pull/17654
  
    Thanks for working on this, remove duplicated code is great. I'm curious as 
to why we couldn't remove some of the function calls to super and instead 
depend on inheritance?
    
    If it's the types on the setters could we add another type parameter of the 
model?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to