Github user mukulmurthy commented on a diff in the pull request:
https://github.com/apache/spark/pull/22473#discussion_r221026721
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -609,13 +609,13 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging with Seria
require(!encryptionEnabled || get(NETWORK_AUTH_ENABLED),
s"${NETWORK_AUTH_ENABLED.key} must be enabled when enabling
encryption.")
- val executorTimeoutThreshold =
getTimeAsSeconds("spark.network.timeout", "120s")
- val executorHeartbeatInterval =
getTimeAsSeconds("spark.executor.heartbeatInterval", "10s")
+ val executorTimeoutThreshold = getTimeAsMs("spark.network.timeout",
"120s")
--- End diff --
This part in the code only does some validation logic on the values and
possibly throws an error. Because we changed it to use
get(EXECUTOR_HEARTBEAT_INTERVAL), which returns the value in ms, I wanted the
other one to return value in ms as well so we're comparing values in the same
unit.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
