Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22579#discussion_r221202958
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala
---
@@ -83,7 +83,7 @@ class SQLAppStatusListener(
// track of the metrics knows which accumulators to look at.
val accumIds = exec.metrics.map(_.accumulatorId).sorted.toList
--- End diff --
Good point. If we use this as `set`, `sort` is not necessary.
When I have just looked at the code, `accumulatorIds` does not take care of
the order of elements. I would appreciate it if someone double-checks it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
