Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r221415826
--- Diff: R/pkg/R/DataFrame.R ---
@@ -246,30 +248,38 @@ setMethod("showDF",
#' @note show(SparkDataFrame) since 1.4.0
setMethod("show", "SparkDataFrame",
function(object) {
- allConf <- sparkR.conf()
- if (!is.null(allConf[["spark.sql.repl.eagerEval.enabled"]]) &&
- identical(allConf[["spark.sql.repl.eagerEval.enabled"]],
"true")) {
- argsList <- list()
- argsList$x <- object
- if
(!is.null(allConf[["spark.sql.repl.eagerEval.maxNumRows"]])) {
- numRows <-
as.numeric(allConf[["spark.sql.repl.eagerEval.maxNumRows"]])
- if (numRows > 0) {
- argsList$numRows <- numRows
+ showFunc <- getOption("sparkr.SparkDataFrame.base_show_func")
--- End diff --
hmm, this naming convention? typically we don't mix `.` and `_` and I don't
think we have anything with `SparkDataFrame`
seems like we have `spark.sparkr.something` before
https://github.com/apache/spark/blob/5264164a67df498b73facae207eda12ee133be7d/core/src/main/scala/org/apache/spark/api/r/RRunner.scala#L343
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
