Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21990#discussion_r221436261
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala ---
    @@ -169,3 +178,29 @@ class SparkSessionExtensions {
         parserBuilders += builder
       }
     }
    +
    +object SparkSessionExtensions extends Logging {
    +
    +  /**
    +   * Initialize extensions if the user has defined a configurator class in 
their SparkConf.
    +   * This class will be applied to the extensions passed into this 
function.
    +   */
    +  private[sql] def applyExtensionsFromConf(conf: SparkConf, extensions: 
SparkSessionExtensions) {
    --- End diff --
    
    Can you just put this in `SparkSession` object and make it `private[spark]`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to