Github user shahidki31 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22592#discussion_r221443587
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
 ---
    @@ -206,11 +238,8 @@ private[ui] abstract class ExecutionTable(
       }
     
       def toNodeSeq(request: HttpServletRequest): Seq[Node] = {
    -    <div>
    -      <h4>{tableName}</h4>
    --- End diff --
    
    > It's just a detail, but I was unclear why you don't need the table name 
anymore.
    
    Table name for running executions was 'Running Queries ({running.size})', 
for  completed executions was 'Completed Queries ({completed.size})' and for 
failed executions was 'Failed Queries ({failed.size})'.
    
    This is already there in the code, inside if condition. 
     ```
              <h4>
                  <span class="collapse-table-arrow arrow-open"></span>
                  <a>Running Queries ({running.size})</a>
                </h4>
    ```
    
    So, the table name is no longer required in this case.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to