Github user gengliangwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22599#discussion_r221637241
  
    --- Diff: 
core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala ---
    @@ -25,7 +25,10 @@ import java.io.{File, FileOutputStream, OutputStream}
     abstract class BenchmarkBase {
       var output: Option[OutputStream] = None
     
    -  def benchmark(): Unit
    +  /**
    +   * Main process of the whole benchmark.
    +   */
    +  def benchmarkSuite(): Unit
    --- End diff --
    
    For the word `suite`, it doesn't have to be about testing.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to