Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r221679693
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -78,4 +80,37 @@ private[spark] object Constants {
val KUBERNETES_MASTER_INTERNAL_URL = "https://kubernetes.default.svc";
val DRIVER_CONTAINER_NAME = "spark-kubernetes-driver"
val MEMORY_OVERHEAD_MIN_MIB = 384L
+
+ // Hadoop Configuration
+ val HADOOP_FILE_VOLUME = "hadoop-properties"
+ val KRB_FILE_VOLUME = "krb5-file"
+ val HADOOP_CONF_DIR_PATH = "/opt/hadoop/conf"
+ val KRB_FILE_DIR_PATH = "/etc"
+ val ENV_HADOOP_CONF_DIR = "HADOOP_CONF_DIR"
+ val HADOOP_CONF_DIR_LOC = "spark.kubernetes.hadoop.conf.dir"
+ val HADOOP_CONFIG_MAP_SPARK_CONF_NAME =
--- End diff --
The name of this constant is very confusing. First of all, can this be
renamed to `HADOOP_CONFIG_MAP_NAME`? Second, looks like
`spark.kubernetes.executor.hadoopConfigMapName` is sufficient.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
