GitHub user ankuriitg opened a pull request:
https://github.com/apache/spark/pull/22616
[SPARK-25586][Core] Remove logdebug statement for outer objects from
ClosureCleaner
## What changes were proposed in this pull request?
Cause: Recently test_glr_summary failed for PR of SPARK-25118, which enables
spark-shell to run with default log level. It failed because this logdebug
was
called for GeneralizedLinearRegressionTrainingSummary which invoked its
toString
method, which started a Spark Job and ended up running into an infinite
loop.
Fix: Remove logDebug statement for outer objects, as in Scala 2.12, closures
aren't implemented with outerclasses and this debug statement looses its
purpose
## How was this patch tested?
Ran python pyspark-ml tests on top of PR for SPARK-25118 and ClosureCleaner
unit
tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ankuriitg/spark ankur/SPARK-25586
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22616.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22616
----
commit cc8926d6a69786412e7630b03d738da8fda7effe
Author: ankurgupta <ankur.gupta@...>
Date: 2018-10-02T16:24:20Z
[SPARK-25586][Core] Remove logdebug statement for outer objects from
ClosureCleaner
Cause: Recently a test_glr_summary failed for PR of SPARK-25118, which
enables
spark-shell to run with default log level. It failed because this logdebug
was
called for GeneralizedLinearRegressionTrainingSummary which invoked its
toString
method, which started a Spark Job and ended up running into an infinite
loop.
Fix: Remove logDebug statement for outer objects, as in Scala 2.12, closures
aren't implemented with outerclasses and this debug statement looses its
purpose
Testing Done:
Ran python pyspark-ml tests on top of PR for SPARK-25118 and ClosureCleaner
unit
tests
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
