Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22598#discussion_r222393501
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -647,4 +647,42 @@ package object config {
           .stringConf
           .toSequence
           .createWithDefault(Nil)
    +
    +  private[spark] val KAFKA_DELEGATION_TOKEN_ENABLED =
    +    ConfigBuilder("spark.kafka.delegation.token.enabled")
    +      .doc("Set to 'true' for obtaining delegation token from kafka.")
    +      .booleanConf
    +      .createWithDefault(false)
    +
    +  private[spark] val KAFKA_BOOTSTRAP_SERVERS =
    +    ConfigBuilder("spark.kafka.bootstrap.servers")
    --- End diff --
    
    hmm, I'm not fond of adding spark specific configs for all of these, does 
kafka client not read the kafka configs to know how to get tokens?  Sorry I 
haven't looked at the kafka implementation yet.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to