Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r222486717
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -59,6 +60,43 @@ case object JVMOffHeapMemory extends ExecutorMetricType {
}
}
+case object ProcessTreeJVMRSSMemory extends ExecutorMetricType {
+ override private[spark] def getMetricValue(memoryManager:
MemoryManager): Long = {
+ ExecutorMetricType.pTreeInfo.updateAllMetrics()
--- End diff --
I think it makes sense for the metrics provider API to return a
`Map[String, Long]` for a set of "named" metrics - we've talked before about
attaching a schema to the metrics bundle passed around by this API. So, similar
to option 2 above.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
