Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r222533085
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -238,7 +262,9 @@ object DecimalLiteral {
/**
* In order to do type checking, use Literal.create() instead of
constructor
*/
-case class Literal (value: Any, dataType: DataType) extends LeafExpression
{
+case class Literal(value: Any, dataType: DataType) extends LeafExpression {
+
+ Literal.validateLiteralValue(value, dataType)
--- End diff --
I think we should not allow it. Can you send a separated PR for this change?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
