Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22630#discussion_r222733663
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -705,13 +709,16 @@ case class HashAggregateExec(
def outputFromRegularHashMap: String = {
s"""
- |while ($iterTerm.next()) {
+ |while ($iterTerm.next()$keepProducingDataCond) {
--- End diff --
Here I only add the stop check for regular hash map. The fast hash map is
small and all in memory, it's ok to always output all of it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
