Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22622#discussion_r222868495
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcSourceSuite.scala 
---
    @@ -182,4 +182,12 @@ class HiveOrcSourceSuite extends OrcSuite with 
TestHiveSingleton {
           }
         }
       }
    +
    +  test("Enforce direct encoding column-wise selectively") {
    +    Seq(true, false).foreach { convertMetastore =>
    +      withSQLConf(HiveUtils.CONVERT_METASTORE_ORC.key -> 
s"$convertMetastore") {
    +        testSelectiveDictionaryEncoding(isSelective = false)
    --- End diff --
    
    When we change Spark behavior later, this test will be adapted according to 
it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to