Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22237#discussion_r222924928
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ParseMode.scala
---
@@ -51,6 +56,8 @@ object ParseMode extends Logging {
case PermissiveMode.name => PermissiveMode
case DropMalformedMode.name => DropMalformedMode
case FailFastMode.name => FailFastMode
+ case NullMalformedMode.name => NullMalformedMode
--- End diff --
After looking at it again, the `mode` option is already there, but
`from_json` ignores it.
Now this PR looks like a bug fix to me. I'm wondering if we do need to keep
the previous behavior. But if we do, I think using a SQL config is more
reasonable than adding a new mode.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
