Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22638#discussion_r222945036
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DatasetCacheSuite.scala ---
    @@ -127,16 +127,16 @@ class DatasetCacheSuite extends QueryTest with 
SharedSQLContext with TimeLimits
       }
     
       test("cache UDF result correctly") {
    -    val expensiveUDF = udf({x: Int => Thread.sleep(5000); x})
    -    val df = spark.range(0, 10).toDF("a").withColumn("b", 
expensiveUDF($"a"))
    +    val expensiveUDF = udf({x: Int => Thread.sleep(2000); x})
    --- End diff --
    
    mmh...since we fail after 2 seconds we may pass this even in case it 
doesn't work. Shall we put it to 3? or 2500 at least?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to