Github user michal-databricks commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21688#discussion_r222984301
  
    --- Diff: core/src/main/scala/org/apache/spark/status/storeTypes.scala ---
    @@ -283,7 +283,10 @@ private[spark] class TaskDataWrapper(
           speculative,
           accumulatorUpdates,
           errorMessage,
    -      metrics)
    +      metrics,
    +      null,
    +      0L,
    --- End diff --
    
    Please pass constant valued parameters by name: `executorLogs = null, 
schedulerDelay = 0L`, etc.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to