Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21669#discussion_r223098530
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/HadoopSparkUserExecutorFeatureStep.scala
 ---
    @@ -0,0 +1,45 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s.features
    +
    +import io.fabric8.kubernetes.api.model.HasMetadata
    +
    +import org.apache.spark.deploy.k8s.{KubernetesConf, SparkPod}
    +import org.apache.spark.deploy.k8s.Constants._
    +import org.apache.spark.deploy.k8s.KubernetesExecutorSpecificConf
    +import org.apache.spark.deploy.k8s.features.hadoopsteps.HadoopBootstrapUtil
    +import org.apache.spark.internal.Logging
    +
    + /**
    +  * This step is responsible for setting ENV_SPARK_USER when HADOOP_FILES 
are detected
    +  * however, this step would not be run if Kerberos is enabled, as 
Kerberos sets SPARK_USER
    +  */
    + private[spark] class HadoopSparkUserExecutorFeatureStep(
    +   kubernetesConf: KubernetesConf[KubernetesExecutorSpecificConf])
    --- End diff --
    
    nit: more indent. Also in other places.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to