Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22615#discussion_r223186360 --- Diff: dev/create-release/release-build.sh --- @@ -191,9 +191,17 @@ if [[ "$1" == "package" ]]; then make_binary_release() { NAME=$1 FLAGS="$MVN_EXTRA_OPTS -B $BASE_RELEASE_PROFILES $2" + # BUILD_PACKAGE can be "withpip", "withr", or both as "withpip,withr" BUILD_PACKAGE=$3 SCALA_VERSION=$4 + if [[ $BUILD_PACKAGE == *"withpip"* ]]; then --- End diff -- @vanzin what do you think of this approach? It simplifies the logic below too, avoiding repeating the main build step 3 times.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org