Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3266#discussion_r20389040
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitDriverBootstrapper.scala
---
@@ -129,6 +129,15 @@ private[spark] object SparkSubmitDriverBootstrapper {
val process = builder.start()
+ Runtime.getRuntime().addShutdownHook(new Thread("Kill SparkSubmit
process") {
--- End diff --
No need to name this thread. Also, could you add a comment here to explain
that this is for killing the app while it's running? Otherwise it's not clear
to me why we need to do this here and do the same at the end of the file again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
