Github user michalsenkyr commented on a diff in the pull request:
https://github.com/apache/spark/pull/22646#discussion_r223212772
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
@@ -1098,12 +1099,19 @@ object SQLContext {
data: Iterator[_],
beanClass: Class[_],
attrs: Seq[AttributeReference]): Iterator[InternalRow] = {
+ import scala.collection.JavaConverters._
+ import java.lang.reflect.{Type, ParameterizedType, Array => JavaArray}
--- End diff --
I didn't want to needlessly add those to the whole file as the reflection
stuff is needed only in this method. Ditto with collection converters. But if
you think it is better at the top, I'll move it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
