Github user darabos commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22673#discussion_r223412612
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
 ---
    @@ -1368,6 +1368,17 @@ class CSVSuite extends QueryTest with 
SharedSQLContext with SQLTestUtils with Te
         })
       }
     
    +  test("SPARK-20144: Keep partition order if allowReordering=false.") {
    +    withSQLConf(
    +      "spark.sql.files.allowReordering" -> "false"
    --- End diff --
    
    If you change this to `true` (or revert the change) the test fails because 
the partitions come back in random order. E.g.:
    
    ```
    Array([5], [6], [7], [8], [9], [0], [1], [2], [3], [4]) did not equal 
Array([0], [1], [2], [3], [4], [5], [6], [7], [8], [9]) (CSVSuite.scala:1378)
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to