Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22029#discussion_r223488428
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/not-in-unit-tests-multi-column-literal.sql
---
@@ -14,8 +14,25 @@ CREATE TEMPORARY VIEW m AS SELECT * FROM VALUES
-- Case 1 (not possible to write a literal with no rows, so we ignore it.)
-- (subquery is empty -> row is returned)
--- Cases 2, 3 and 4 are currently broken, so I have commented them out
here.
--- Filed https://issues.apache.org/jira/browse/SPARK-24395 to fix and
restore these test cases.
+ -- Case 2
+ -- (subquery contains a row with null in all columns -> row not returned)
--- End diff --
Ur, do we need the two spaces at the beginning?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
