Github user ankuriitg commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22504#discussion_r223519892
  
    --- Diff: core/src/main/scala/org/apache/spark/internal/Logging.scala ---
    @@ -192,7 +211,15 @@ private[spark] object Logging {
             defaultSparkLog4jConfig = false
             LogManager.resetConfiguration()
           } else {
    -        LogManager.getRootLogger().setLevel(defaultRootLevel)
    +        val rootLogger = LogManager.getRootLogger()
    +        rootLogger.setLevel(defaultRootLevel)
    +        rootLogger.getAllAppenders().asScala.foreach { tmp =>
    --- End diff --
    
    Not really, consoleAppenderToThreshold was added later. Additionally, 
currently I do not store any consoleAppender which have null threshold into 
this map. In order for doing this way, I will need to store those as well. 
Dropping this, as in most scenarios, this will require more storage and minor 
performance improvement.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to