Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22466#discussion_r223569182
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala 
---
    @@ -53,6 +53,7 @@ class HiveCatalogedDDLSuite extends DDLSuite with 
TestHiveSingleton with BeforeA
           // drop all databases, tables and functions after each test
           spark.sessionState.catalog.reset()
         } finally {
    +      Utils.deleteRecursively(new 
File(spark.sessionState.conf.warehousePath))
    --- End diff --
    
    We dropped all the database in line 54, right? Could you fix the test cases 
instead of delete the directory here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to