Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22624#discussion_r223766345
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosHadoopDelegationTokenManager.scala
 ---
    @@ -14,147 +14,39 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    -
     package org.apache.spark.scheduler.cluster.mesos
     
    -import java.security.PrivilegedExceptionAction
    -import java.util.concurrent.{ScheduledExecutorService, TimeUnit}
    -
     import org.apache.hadoop.conf.Configuration
    -import org.apache.hadoop.security.UserGroupInformation
    +import org.apache.hadoop.security.{Credentials, UserGroupInformation}
     
     import org.apache.spark.SparkConf
    -import org.apache.spark.deploy.SparkHadoopUtil
    +import org.apache.spark.deploy.security.AbstractCredentialRenewer
     import org.apache.spark.deploy.security.HadoopDelegationTokenManager
    -import org.apache.spark.internal.{config, Logging}
     import org.apache.spark.rpc.RpcEndpointRef
    -import 
org.apache.spark.scheduler.cluster.CoarseGrainedClusterMessages.UpdateDelegationTokens
    -import org.apache.spark.ui.UIUtils
    -import org.apache.spark.util.ThreadUtils
    -
     
     /**
    - * The MesosHadoopDelegationTokenManager fetches and updates Hadoop 
delegation tokens on the behalf
    - * of the MesosCoarseGrainedSchedulerBackend. It is modeled after the YARN 
AMCredentialRenewer,
    - * and similarly will renew the Credentials when 75% of the renewal 
interval has passed.
    - * The principal difference is that instead of writing the new credentials 
to HDFS and
    - * incrementing the timestamp of the file, the new credentials (called 
Tokens when they are
    - * serialized) are broadcast to all running executors. On the executor 
side, when new Tokens are
    - * received they overwrite the current credentials.
    + * Mesos-specific implementation of AbstractCredentialRenewer.
      */
     private[spark] class MesosHadoopDelegationTokenManager(
    --- End diff --
    
    That's the existing name and I'd rather not change it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to