Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22687#discussion_r224021798
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
 ---
    @@ -534,6 +534,13 @@ private[parquet] class ParquetFilters(
                 createFilterHelper(nameToParquetField, rhs, 
canPartialPushDownConjuncts = false)
             } yield FilterApi.or(lhsFilter, rhsFilter)
     
    +      case sources.Not(sources.Or(lhs, rhs)) if 
canPartialPushDownConjuncts =>
    +        createFilterHelper(nameToParquetField,
    +          sources.And(sources.Not(lhs), sources.Not(rhs)), 
canPartialPushDownConjuncts = true)
    +
    +      case sources.Not(sources.Not(pred)) if canPartialPushDownConjuncts =>
    --- End diff --
    
    hm, is this actually reachable?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to