Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21816#discussion_r224128493
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/rest/StandaloneRestSubmitSuite.scala
 ---
    @@ -83,6 +83,26 @@ class StandaloneRestSubmitSuite extends SparkFunSuite 
with BeforeAndAfterEach {
         assert(submitResponse.success)
       }
     
    +  test("create submission with multiple masters") {
    +    val submittedDriverId = "your-driver-id"
    +    val submitMessage = "my driver is submitted"
    +    val masterUrl = startDummyServer(submitId = submittedDriverId, 
submitMessage = submitMessage)
    +    val conf = new SparkConf(loadDefaults = false)
    +    val RANDOM_PORT = 9000
    +    val allMasters = "%s,%s:%d".format(masterUrl, Utils.localHostName(), 
RANDOM_PORT)
    --- End diff --
    
    Can we use interpolation here? Below, I'm not sure anything tests that the 
new master config takes hold?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to