Github user szyszy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20761#discussion_r224193837
  
    --- Diff: 
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
 ---
    @@ -87,6 +88,20 @@ class YarnAllocatorSuite extends SparkFunSuite with 
Matchers with BeforeAndAfter
       def createAllocator(
           maxExecutors: Int = 5,
           rmClient: AMRMClient[ContainerRequest] = rmClient): YarnAllocator = {
    +    createAllocatorInternal(maxExecutors, rmClient, Map())
    +  }
    +
    +  def createAllocatorWithAdditionalConfigs(
    --- End diff --
    
    Fair enough, fixed.
    Did similarly with the `createResource` method.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to