Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3197#discussion_r20400214
--- Diff: core/src/main/scala/org/apache/spark/SparkStatusAPI.scala ---
@@ -140,3 +103,10 @@ private[spark] trait SparkStatusAPI { this:
SparkContext =>
}
}
}
+
+private[spark] object SparkStatusAPI {
--- End diff --
Sorry the main problem I have is that I don't get why we need to protect
the constructor at all. It is not something we expect the users to call. Why
don't you just remove all of these stuff, and add a line in javadoc for the
constructor saying we don't expect users to call this constructor?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
