Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22699#discussion_r224504103
  
    --- Diff: sbin/start-history-server.sh ---
    @@ -28,7 +28,22 @@ if [ -z "${SPARK_HOME}" ]; then
       export SPARK_HOME="$(cd "`dirname "$0"`"/..; pwd)"
     fi
     
    +# NOTE: This exact class name is matched downstream by SparkSubmit.
    +# Any changes need to be reflected there.
    +CLASS="org.apache.spark.deploy.history.HistoryServer"
    +
    +if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
    +  echo "Usage: ./sbin/start-history-server.sh [options]"
    --- End diff --
    
    nit: why not have a separated `usage()` function?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to