Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r224660195
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -69,11 +69,22 @@ trait ExpressionEvalHelper extends
GeneratorDrivenPropertyChecks with PlanTestBa
/**
* Check the equality between result of expression and expected value,
it will handle
- * Array[Byte], Spread[Double], MapData and Row.
+ * Array[Byte], Spread[Double], MapData and Row. Also check whether
nullable in expression is
+ * true if result is null
*/
- protected def checkResult(result: Any, expected: Any, exprDataType:
DataType): Boolean = {
+ protected def checkResult(result: Any, expected: Any, expression:
Expression): Boolean = {
+ checkResult(result, expected, expression.dataType, expression.nullable)
+ }
+
+ protected def checkResult(
+ result: Any,
+ expected: Any,
+ exprDataType: DataType,
+ exprNullable: Boolean): Boolean = {
val dataType = UserDefinedType.sqlType(exprDataType)
+ // The result is null for a non-nullable expression
+ assert(result != null || exprNullable, "exprNullable should be true if
result is null")
--- End diff --
nit: how about "result cannot be null since it's not nullable."
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
