Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22713
Thanks @gatorsmile, I agree. Then I reduced the scope to only the analyzer
rules and added the UT for the only rule changed (other than the
`AliasViewChild` one which is tested with the code provided by @maryannxue).
I removed the changes in the `Analyzer`, because those cases are hard to
test, in the sense that I have not found operators causing problems for them,
as they rely on working on operators which bring the very same `output` (eg. in
one case the very same plan is used, in the other all the operators I have seen
just do `def output = child.output`, so the output is really the same). So
despite I think the changes there should be done, I am ok leaving them out of
scope here as they are of no harm.
Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
