Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22501#discussion_r224985471
--- Diff:
core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala ---
@@ -48,15 +48,11 @@ abstract class BenchmarkBase {
if (!file.exists()) {
file.createNewFile()
}
- output = Some(new FileOutputStream(file))
+ output = Option(new FileOutputStream(file))
--- End diff --
My point was that there's no point of checking `null` below from my cursory
look. If there's no chance that it becomes `null`, we can leave it `Some` and
remove `null` check below.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
