Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22727#discussion_r225179121
  
    --- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala
 ---
    @@ -71,6 +71,12 @@ object HiveThriftServer2 extends Logging {
       }
     
       def main(args: Array[String]) {
    +    // If the arguments contains "-h" or "--help", print out the usage and 
exit.
    +    if (args.contains("-h") || args.contains("--help")) {
    +      HiveServer2.main(args)
    --- End diff --
    
    That's reasonable. But just return in the line below. System.exit is 
unnecessarily abrupt.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to