Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22597#discussion_r225404390
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcTest.scala
---
@@ -106,4 +106,14 @@ abstract class OrcTest extends QueryTest with
SQLTestUtils with BeforeAndAfterAl
df: DataFrame, path: File): Unit = {
df.write.mode(SaveMode.Overwrite).orc(path.getCanonicalPath)
}
+
+ protected def checkPredicatePushDown(df: DataFrame, numRows: Int,
predicate: String): Unit = {
--- End diff --
@HyukjinKwon . I refactor this since it's repeated three times now.
And, this function should be here because the existing two instances are in
`OrcQueryTest` and new instance is in `OrcQuerySuite`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
