Github user vofque commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22708#discussion_r225505036
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
 ---
    @@ -271,32 +272,41 @@ object JavaTypeInference {
     
           case c if listType.isAssignableFrom(typeToken) =>
             val et = elementType(typeToken)
    -        MapObjects(
    +        UnresolvedMapObjects(
    --- End diff --
    
    Removed other changes from this PR and created a new one with only map case.
    As far as I see, everything works fine with scala classes, because 
StructTypes are generated based on constructor parameters, and they are 
available in correct order with correct names. Which is hardly achievable with 
Java beans..


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to