GitHub user obermeier reopened a pull request:

    https://github.com/apache/spark/pull/19408

    [SPARK-22180][CORE] Allow IPv6 address in 
org.apache.spark.util.Utils.parseHostPort

    External applications like Apache Cassandra are able to deal with IPv6 
addresses. Libraries like spark-cassandra-connector combine Apache Cassandra 
with Apache Spark.
    This combination is very useful IMHO.
    
    One problem is that `org.apache.spark.util.Utils.parseHostPort(hostPort:` 
`String)` takes the last colon to sepperate the port from host path. This 
conflicts with literal IPv6 addresses.
    
    I think we can take `hostPort` as literal IPv6 address if it contains tow 
ore more colons. If IPv6 addresses are enclosed in square brackets port 
definition is still possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/obermeier/spark issue/SPARK-22180

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19408
    
----
commit 453e104c3e6ed6a5ca310f599c274d6c66a3d3c8
Author: Stefan Obermeier <mail@...>
Date:   2017-10-01T14:28:58Z

    [SPARK-22180][CORE] Allow IPv6 address in 
org.apache.spark.util.Utils.parseHostPort
    
    ## What changes were proposed in this pull request?
    
    Take ```hostPort``` as literal IPv6 address if it contains tow ore more 
colons. If IPv6 addresses are enclosed in square brackets port definition is 
still possible.
    
    ## How was this patch tested?
    
    Added a new test case into UtilsSuite
    
    Remove comment

commit 1e6623f518b43df4079bdc2680288063c6be13c6
Author: obermeier <obermeier@...>
Date:   2017-12-14T22:52:21Z

    Merge branch 'master' into issue/SPARK-22180

commit 1400299808631da0196a61f3588ede786dd0b041
Author: Stefan Obermeier <mail@...>
Date:   2017-12-15T07:39:45Z

    Fix build problem

commit 68c322129305a35c9d3e04f8cacc011be5fbaec4
Author: Stefan Obermeier <mail@...>
Date:   2017-12-18T13:51:04Z

    Fix style checks violation.
    
    Remove whitespace at end of line.

commit 8220d95a99f4564e735f22947cb1cb698613efa5
Author: Stefan Obermeier <scray@...>
Date:   2018-10-09T21:54:20Z

    Add log message if hostname:port is not valid

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to