Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22263#discussion_r226184242
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
    @@ -288,6 +297,65 @@ class CachedTableSuite extends QueryTest with 
SQLTestUtils with SharedSQLContext
         }
       }
     
    +  test("SQL interface support storageLevel(DISK_ONLY)") {
    --- End diff --
    
    @wangyum . Originally, I thought you can make a utility function for those 
4 test cases. 
    The utility function can accept `sql` statement and `storagelevel`. Then, 4 
test cases will have simpler body.
    > They are mostly the same except SQL statements and StorageLevels.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to