Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22732#discussion_r226527439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -932,6 +935,23 @@ trait ScalaReflection {
tpe.dealias.erasure.typeSymbol.asClass.fullName
}
+ /**
+ * Returns the nullability of the input parameter types of the scala
function object.
+ *
+ * Note that this only works with Scala 2.11, and the information
returned may be inaccurate if
+ * used with a different Scala version.
--- End diff --
The argument here is it's not necessarily wrong if using scala 2.12. if all
inputs are of boxed types, then it can still be good. I think it's just enough
to say "we don't support it. switch to the new interface otherwise we can't
guarantee correctness."
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
