Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/22760#discussion_r227062895 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala --- @@ -78,6 +79,12 @@ private[spark] case class KubernetesConf[T <: KubernetesRoleSpecificConf]( def krbConfigMapName: String = s"$appResourceNamePrefix-krb5-file" + // For unit-testing purposes + def hadoopBootstrapUtil: HadoopBootstrapUtil = new HadoopBootstrapUtil() --- End diff -- KubernetesConf might not be the right place for hadoopBootstrapUtil, hadoopKerberosLogin, and tokenManager - I'd expect KubernetesConf to just be a struct-like object. Can we rewrite these things such that these modules are injected into the constructors? We can use default implementations and override in tests.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org